Allow Clippy to define duplicate extra symbols #143596
Open
+576
−441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
This comment has been minimized.
This comment has been minimized.
Alexendoo
force-pushed
the
clippy-allow-duplicate-symbols
branch
from
393f4ae to
aebfd04
Compare
|
This seems to be quite above my personal threshold for the compiler to maintain and support this, since it isn't a mechanism used by the compiler itself. Do you think there could be an easier solution here? For example, rustc may expose the number of symbols, then clippy could scan the rustc list (either the file itself, or exposed through a constant) to error at compile time if there is a duplicate symbol. Or clippy could use a |
fee1-dead
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142410 (comment)
rustc_macros::symbolsnow also expands to a macroextra_symbolsthat callsrustc_macros::extra_symbols_implwith the prefill stream so that it can know which symbols are duplicatedextra_symbolsallows supplying a name to define a macro to provide even more extra symbols, this is useful for external drivers that rely onclippy_utilse.g. TheBevyFlock/bevy_cli#456There's a usage example in
compiler/rustc_span/src/symbol/tests.rsDUPLICATE_SYMBOLSis currently unused, but we can use it on the clippy side to remove duplicates without interfering withr-l/rustPRs